Feature/71 Revise Message Subscription Endpoint #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the endpoint used for message subscriptions. Bases it off of an analysis which moves the analysis identifier from the request body to the actual URL. This has been done to put an emphasis on the fact that subscriptions for messages are grouped by an analysis identifier. Also adds existence checks before adding a message subscription. When an analysis does not exist on the central side (hub) then the client must not be able to add a message subscription. This is done because there won't be any incoming messages if for an analysis if it does not exist in the first place.
DiCanio
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #71.
Adjusts the endpoint used for message subscriptions. Bases it off of an analysis which moves the analysis identifier from the request body to the actual URL.
This has been done to put an emphasis on the fact that subscriptions for messages are grouped by an analysis identifier.
Also adds existence checks before adding a message subscription. When an analysis does not exist on the central side (hub) then the client must not be able to add a message subscription.
This is done because there won't be any incoming messages if for an analysis if it does not exist in the first place.